Skip to content

Remove duplicate date parsing in Post_Command.php #575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
swissspidy merged 1 commit into from
Feb 10, 2026
Merged

Remove duplicate date parsing in Post_Command.php #575

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/Post_Command.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -779,7 +779,6 @@ public function generate( $args, $assoc_args ) {

// Add time if the string is a valid date without time.
$date = DateTime::createFromFormat( 'Y-m-d', $post_data['post_date'] );
$date = DateTime::createFromFormat( 'Y-m-d', $post_data['post_date'] );
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Feb 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While removing this duplicate line is correct, the overall logic for appending a default time to post_date is duplicated for post_date_gmt a few lines below (lines 786-789). To improve maintainability and adhere to the DRY (Don't Repeat Yourself) principle, consider extracting this logic into a private helper method.

if ( $date && $date->format( 'Y-m-d' ) === $post_data['post_date'] ) {
$post_data['post_date'] .= ' 00:00:00';
}
Expand Down
Loading