Skip to content

Remove duplicate date parsing in Post_Command.php#575

Merged
swissspidy merged 1 commit intowp-cli:mainfrom
Soean:remove_duplicate
Feb 10, 2026
Merged

Remove duplicate date parsing in Post_Command.php#575
swissspidy merged 1 commit intowp-cli:mainfrom
Soean:remove_duplicate

Conversation

@Soean
Copy link
Contributor

@Soean Soean commented Feb 10, 2026

This pull request includes a minor cleanup in the generate method of Post_Command.php. An unnecessary duplicate line that created a DateTime object from the post date was removed to simplify the code.

@Soean Soean requested a review from a team as a code owner February 10, 2026 13:50
@github-actions
Copy link
Contributor

Hello! 👋

Thanks for opening this pull request! Please check out our contributing guidelines. We appreciate you taking the initiative to contribute to this project.

Contributing isn't limited to just code. We encourage you to contribute in the way that best fits your abilities, by writing tutorials, giving a demo at your local meetup, helping other users with their support questions, or revising our documentation.

Here are some useful Composer commands to get you started:

  • composer install: Install dependencies.
  • composer test: Run the full test suite.
  • composer phpcs: Check for code style violations.
  • composer phpcbf: Automatically fix code style violations.
  • composer phpunit: Run unit tests.
  • composer behat: Run behavior-driven tests.

To run a single Behat test, you can use the following command:

# Run all tests in a single file
composer behat features/some-feature.feature

# Run only a specific scenario (where 123 is the line number of the "Scenario:" title)
composer behat features/some-feature.feature:123

You can find a list of all available Behat steps in our handbook.

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Soean, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request streamlines the generate method in Post_Command.php by eliminating a redundant line of code. The change focuses on improving code clarity and maintainability without altering the existing functionality, specifically by removing an unnecessary duplicate date parsing operation.

Highlights

  • Code Cleanup: Removed a duplicate DateTime::createFromFormat call within the generate method of Post_Command.php.
Changelog
  • src/Post_Command.php
    • Removed a redundant DateTime::createFromFormat call that was duplicating an adjacent line.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@github-actions github-actions bot added bug command:post Related to 'post' command command:post-generate Related to 'post generate' command labels Feb 10, 2026
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly removes a redundant line of code in Post_Command.php. The change is a good cleanup. I've added one suggestion to address code duplication in the surrounding code, which could be handled in a follow-up to further improve maintainability.


// Add time if the string is a valid date without time.
$date = DateTime::createFromFormat( 'Y-m-d', $post_data['post_date'] );
$date = DateTime::createFromFormat( 'Y-m-d', $post_data['post_date'] );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

While removing this duplicate line is correct, the overall logic for appending a default time to post_date is duplicated for post_date_gmt a few lines below (lines 786-789). To improve maintainability and adhere to the DRY (Don't Repeat Yourself) principle, consider extracting this logic into a private helper method.

@codecov
Copy link

codecov bot commented Feb 10, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@swissspidy swissspidy added this to the 2.9.0 milestone Feb 10, 2026
@swissspidy swissspidy merged commit 35177d7 into wp-cli:main Feb 10, 2026
65 of 66 checks passed
@Soean Soean deleted the remove_duplicate branch February 11, 2026 07:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug command:post Related to 'post' command command:post-generate Related to 'post generate' command

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants