chore(lint): enforce more strict eslint/oxlint rules (batch 2) #37884
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade more lint rules from warn to error: - unicorn/no-useless-length-check - no-constant-binary-expression - no-unsafe-optional-chaining Add new rules: - storybook/prefer-pascal-case - react-you-might-not-need-an-effect/no-reset-all-state-on-prop-change - react-you-might-not-need-an-effect/no-chain-state-updates - react-you-might-not-need-an-effect/no-event-handler - react-you-might-not-need-an-effect/no-derived-state Fix violations: - state.ts: Remove redundant array length checks (every() handles empty arrays) - buildQuery.ts: Move nullish coalescing inside Number() call - Modal.tsx: Remove unnecessary optional chaining on document.documentElement - Layout.test.tsx: Extract boolean to variable to avoid constant expression - transformProps.test.ts: Use non-null assertion instead of optional chaining Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Code Review Agent Run #9ab59aActionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
Contributor
Sequence DiagramThis PR tightens ESLint/oxlint rules and applies minimal code fixes (remove redundant length checks, fix nullish/coercion order, remove unsafe optional chaining, and update tests) so linting passes. The diagram shows the main developer → linter → code → tests flow. sequenceDiagram
participant Dev as Developer
participant Config as Lint Config (oxlint/.eslintrc)
participant Repo as Codebase
participant Linter as Lint Runner (npx oxlint / npm run lint)
participant Tests as Test Runner
Dev->>Config: Upgrade rules to errors (no-unsafe-optional-chaining, no-constant-binary-expression, unicorn/no-useless-length-check, add react-you-might-not-need-an-effect, storybook rule)
Dev->>Repo: Apply focused fixes (remove .length checks, move ?? inside Number(), remove ?., adjust tests)
Dev->>Linter: Run linter
Linter->>Repo: Analyze code against updated rules
Repo-->>Linter: No lint errors (fixes applied)
Dev->>Tests: Run tests
Tests-->>Dev: Tests pass
Generated by CodeAnt AI |
This was referenced Feb 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Second batch of lint rule upgrades from warn to error, continuing to reduce tech debt.
Rules upgraded from warn → error
unicorn/no-useless-length-check.length === 0checks before.every()no-constant-binary-expressionNumber(x) ?? 0→Number(x ?? 0), extract test booleans to variablesno-unsafe-optional-chaining?.on always-defined properties, use!assertion in testsNew rules added (set to error)
storybook/prefer-pascal-casereact-you-might-not-need-an-effect/no-reset-all-state-on-prop-changereact-you-might-not-need-an-effect/no-chain-state-updatesreact-you-might-not-need-an-effect/no-event-handlerreact-you-might-not-need-an-effect/no-derived-stateNotable fixes
Useless length check:
arr.length === 0 || arr.every(...)is redundant sinceevery()returnstruefor empty arraysConstant binary expression:
Number(formData?.row_limit) ?? 0never uses the fallback sinceNumber()always returns a number (possibly NaN). Fixed toNumber(formData?.row_limit ?? 0)Unsafe optional chaining:
window?.document?.documentElementwith destructuring is unsafe. In browser context, these are always defined, so removed the optional chaining.BEFORE/AFTER SCREENSHOTS OR COVERAGE
N/A - lint configuration changes only
TESTING INSTRUCTIONS
npx oxlint -c oxlint.json- should have no errors for upgraded rulesnpm run lint- should pass🤖 Generated with Claude Code