chore(lint): upgrade array creation, effect, and TypeScript rules #37885
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgrade unicorn/no-new-array to error (all violations fixed)
- Upgrade @typescript-eslint/no-use-before-define from warn to error
- Add react-you-might-not-need-an-effect plugin with rules:
- no-adjust-state-on-prop-change: error
- no-pass-data-to-parent: error
Fixed unicorn/no-new-array violations by replacing:
- new Array(n).fill().map() with Array.from({ length: n }, callback)
- new Array(n).fill().join() with String.repeat()
- new Array(n).fill().forEach() with for loops
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
Code Review Agent Run #6a62f8Actionable Suggestions - 0Review Details
Bito Usage GuideCommands Type the following command in the pull request comment and save the comment.
Refer to the documentation for additional commands. Configuration This repository uses Documentation & Help AI Code Review powered by |
Contributor
Sequence DiagramThis PR tightens ESLint/TypeScript/react-effect rules and applies automated fixes across the codebase—primarily replacing unsafe new Array(...) patterns with Array.from / String.repeat / for-loops—so lint now reports zero violations and CI passes. sequenceDiagram
participant Developer
participant Repo
participant LinterConfig as "ESLint & oxlint"
participant CodeMods as "Codemods/Manual Edits"
participant CI
Developer->>Repo: Update lint config (rules -> error) and apply fixes
Repo->>CodeMods: Run codemods / replace new Array(...) patterns
CodeMods-->>Repo: Commit transformed files (Array.from, '0'.repeat, for-loops)
Repo->>LinterConfig: Lint rules now stricter (unicorn/no-new-array, @typescript-eslint, react-effect)
CI->>Repo: Run lint checks
LinterConfig-->>CI: No violations
CI-->>Developer: Merge/CI passes (lint green)
Generated by CodeAnt AI |
msyavuz
approved these changes
Feb 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Third batch of lint cleanup to reduce tech debt and enforce stricter patterns.
Rules upgraded to error:
unicorn/no-new-array- PreferArray.from({ length: n }, callback)overnew Array(n).fill().map()@typescript-eslint/no-use-before-define- Previously at warn, now error (no violations found)react-you-might-not-need-an-effect/no-adjust-state-on-prop-change- New rule addedreact-you-might-not-need-an-effect/no-pass-data-to-parent- New rule addedFixes applied:
Fixed all
unicorn/no-new-arrayviolations across 17 files by replacing:new Array(n).fill().map(callback)→Array.from({ length: n }, callback)new Array(n).fill(0).join('')→'0'.repeat(n)new Array(n).fill().forEach(callback)→forloopWhy prefer Array.from?
new Array(n).fill().map()has several issues:.fill()alone creates holes that behave unexpectedly with array methodsArray.from({ length: n }, callback)is more readable and directBEFORE/AFTER
Before:
After:
TESTING INSTRUCTIONS
These are lint rule changes. CI will verify all linting passes.
ADDITIONAL INFORMATION
🤖 Generated with Claude Code