-
Notifications
You must be signed in to change notification settings - Fork 25
Add missing event types #543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add missing event types #543
Conversation
Greptile OverviewGreptile SummaryAdded 21 missing event types from WorkOS documentation to align SDK with API capabilities. Created 5 new payload model files ( The changes follow existing patterns:
Confidence Score: 5/5
Important Files Changed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
11 files reviewed, 1 comment
|
|
||
|
|
||
| class FlagPayload(WorkOSModel): | ||
| object: str |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Inconsistent type annotation - use Literal["flag"] instead of str for consistency with other payload models like ApiKeyPayload, PermissionPayload, and OrganizationRolePayload
| object: str | |
| object: Literal["flag"] |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Add support for the following event types that were documented but missing from the SDK: - api_key.created, api_key.revoked - authentication.email_verification_failed, authentication.mfa_failed, authentication.passkey_failed, authentication.passkey_succeeded, authentication.radar_risk_detected - connection.saml_certificate_renewed, connection.saml_certificate_renewal_required - flag.created, flag.updated, flag.deleted, flag.rule_updated - invitation.resent - organization_role.created, organization_role.deleted, organization_role.updated - permission.created, permission.deleted, permission.updated New payload models: ApiKeyPayload, ConnectionSamlCertificate payloads, FlagPayload, OrganizationRolePayload, PermissionPayload. New auth payloads for email_verification_failed, mfa_failed, passkey, and radar_risk_detected. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
8f96bf8 to
02de12d
Compare
Description
This was entirely written by pointing claude at the workos docs because it's such manual work
https://workos.com/docs/events but absent from the SDK:
api_key.created,api_key.revoked,authentication.email_verification_failed,authentication.mfa_failed,authentication.passkey_failed,authentication.passkey_succeeded,authentication.radar_risk_detected,connection.saml_certificate_renewed,connection.saml_certificate_renewal_required,flag.created,flag.updated,flag.deleted,flag.rule_updated,invitation.resent,organization_role.created,organization_role.deleted,organization_role.updated,permission.created,permission.deleted,permission.updatedApiKeyPayload,ConnectionSamlCertificate*Payload,FlagPayload,OrganizationRolePayload,PermissionPayload) and new auth payloads for the missing authentication eventsEventTypeliteral,Event/Webhookdiscriminated unions,EventPayloadTypeVar, and__init__.pybarrel exportsDocumentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.