fix(cc-digital-channels): get-theme-value-from-store#625
fix(cc-digital-channels): get-theme-value-from-store#625akulakum wants to merge 4 commits intowebex:nextfrom
Conversation
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
|
@codex review |
|
To use Codex here, create a Codex account and connect to github. |
| }} | ||
| > | ||
| <DigitalChannelsInternal {...props} /> | ||
| <DigitalChannelsInternal /> |
There was a problem hiding this comment.
We should still be passing the theme prop to the Internal Digital Channels widget that is built by the WxEngage team, right?
There was a problem hiding this comment.
Yes, the theme is still being passed to DigitalChannelsComponent which renders the WxEngage Engage widget. The change is that instead of receiving currentTheme as a prop from the consumer, we now read it directly from store.currentTheme for consistency with other store-managed values like dataCenter and jwtToken.
COMPLETES #https://jira-eng-sjc12.cisco.com/jira/browse/CAI-7624
This pull request addresses
The Digital Channels Widget was accepting currentTheme as a prop, requiring each consumer to pass the theme value explicitly. This was inconsistent with other store-managed values like dataCenter and jwtToken which are read directly from the store
by making the following changes
Change Type
The following scenarios were tested
< ENUMERATE TESTS PERFORMED, WHETHER MANUAL OR AUTOMATED >
The GAI Coding Policy And Copyright Annotation Best Practices
Checklist before merging
Make sure to have followed the contributing guidelines before submitting.