Refactor log package #4734
Open
Refactor log package #4734
+116
−118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the caller to do the error handling.
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 2 potential issues.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| func WithCore(core zapcore.Core) logConfig { | ||
| return logConfig{core: core} | ||
| func WithCore(core zapcore.Core) zapcore.Core { | ||
| return core |
There was a problem hiding this comment.
WithCore is now a redundant identity function
Low Severity
WithCore previously wrapped a zapcore.Core in a logConfig struct, which was meaningful. After this refactoring, since functions now return zapcore.Core directly, WithCore just returns its argument unchanged — it's a pure identity function. It's also unused anywhere in the codebase.
Contributor
Author
There was a problem hiding this comment.
I'm okay with this redundancy, but if a human objects I can remove it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Refactor some parts of the
logpackage to simplify the internals. NB this is a breaking change forWithSentryandAddSentryfunctions.Checklist:
make test-community)?make lintthis requires golangci-lint)?