-
-
Notifications
You must be signed in to change notification settings - Fork 1k
docs: cursor cli docs update (remove chmod workaround) #3031
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
WalkthroughThe Cursor CLI build extension setup has been refactored to change the export pattern from a pre-defined extension object to a function that returns a BuildExtension. A module-level CURSOR_AGENT_DIR constant is introduced to define the target path for the agent binary. The onBuildComplete handler now includes build-time gating to skip execution when the target is "dev". The build layer logic is restructured to install runtime dependencies, update PATH, execute the official Cursor installer, and copy the resulting binary to CURSOR_AGENT_DIR, replacing the previous direct COPY and CHMOD approach. Internal function parameters are renamed from params to context. Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docs/guides/example-projects/cursor-background-agent.mdx (1)
63-84:⚠️ Potential issue | 🟡 MinorInclude the missing
BuildExtensionimport with correct package path.The snippet references
BuildExtensionon line 66 but doesn't show the import. Add this to the top of the code block:Missing import
import type { BuildExtension } from "@trigger.dev/build";Additionally, note that
cursorCliis now a factory function—it must be called ascursorCli()(notcursorCli) when adding it to theextensionsarray intrigger.config.ts. The linked GitHub repo (line 109) shows the correct usage pattern.
📜 Review details
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
docs/guides/example-projects/cursor-background-agent.mdx
🧰 Additional context used
🧠 Learnings (2)
📓 Common learnings
Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-11-27T16:27:35.304Z
Learning: Applies to **/trigger.config.ts : Use build extensions in trigger.config.ts (additionalFiles, additionalPackages, aptGet, prismaExtension, etc.) to customize the build
📚 Learning: 2025-11-27T16:27:35.304Z
Learnt from: CR
Repo: triggerdotdev/trigger.dev PR: 0
File: .cursor/rules/writing-tasks.mdc:0-0
Timestamp: 2025-11-27T16:27:35.304Z
Learning: Applies to **/trigger.config.ts : Use build extensions in trigger.config.ts (additionalFiles, additionalPackages, aptGet, prismaExtension, etc.) to customize the build
Applied to files:
docs/guides/example-projects/cursor-background-agent.mdx
🔇 Additional comments (2)
docs/guides/example-projects/cursor-background-agent.mdx (2)
61-61: LGTM! The updated description accurately reflects the new build approach — running the official installer at build time and copying the resolved binary to a fixed path.
68-69: Good addition: dev-target gating. Skipping the layer installation duringdevbuilds avoids unnecessary work in local development. Clean implementation.
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
Uh oh!
There was an error while loading. Please reload this page.