adds virtual thread support for activity execution context#2784
adds virtual thread support for activity execution context#2784TbirdDuncan wants to merge 1 commit intotemporalio:masterfrom
Conversation
|
TristanAnderson seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Hello @TbirdDuncan, thanks for your contribution. Note that I can't take a look at your PR until you've signed the CLA. See the link to sign the CLA in messages from CLAassistant above. Also, I'm puzzled by your description. As far as I see, there's nothing in Would you mind opening an issue ticket providing details on what issues you faced? |
I can open an issue, also looks like some weird git stuff going on with my user. I'll try and resolve that, signing the agreement doesn't seem to resolve it. |
I believe this happens when the email in your commit is not the one associated with your github account. |
> updates CurrentActivityExecutionContext.java to support that mission > adds test for CurrentActivityExecutionContextTest > removed unused code in temporal-sdk/src/test/java/io/temporal/internal/nexus/WorkflowRunTokenTest.java
Well i'll be damned, I guess this is why its important to open an issue first. I can't replicate it with recent versions... |
What was changed
The activity execution context is now usable within virtual threads
Why?
I was working a temporal project, and went to make use of virtual threads. I noted that I was unable to use the activityexecutioncontext inside of the virtual thread. After reading the error message I realized the reasoning wasn't sufficient, and decided to check if the code just hadn't implemented it.
There are unit tests, also created a local testing suite against a built image