Refactor MeteredEmbeddingProvider to be only wrapper, not sub-class, renamed as MeteredEmbeddingProviderWrapper#2397
Merged
tatu-at-datastax merged 5 commits intomainfrom Feb 17, 2026
Conversation
Contributor
📉 Unit Test Coverage Delta vs Main Branch
|
Contributor
Unit Test Coverage Report
|
Contributor
📈 Integration Test Coverage Delta vs Main Branch (dse69-it)
|
Contributor
Integration Test Coverage Report (dse69-it)
|
Contributor
📈 Integration Test Coverage Delta vs Main Branch (hcd-it)
|
Contributor
Integration Test Coverage Report (hcd-it)
|
tatu-at-datastax
changed the title
MeteredEmbeddingProvider to be only wrapper, not sub-class (to be renamed)MeteredEmbeddingProvider to be only wrapper, not sub-class, renamed as MeteredEmbeddingProviderWrapper
amorton
approved these changes
Feb 17, 2026
| private static final Logger LOGGER = LoggerFactory.getLogger(MeteredEmbeddingProvider.class); | ||
|
|
||
| private static final String UNKNOWN_TENANT_ID = "unknown"; | ||
| public class MeteredEmbeddingProviderWrapper { |
Contributor
There was a problem hiding this comment.
Agree, and as discussed ultimately we should look at refactoring so a class like this just has methods to record the metrics and it's up the Provider to know what and when to record them.
tatu-at-datastax
deleted the
tatu/refactor-metered-embedding-provider
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Refactor
MeteredEmbeddingProviderso it is no longer a sub-class ofEmbeddingProvider(because it really isn't sub-type); leaving as a wrapper. Also renamed asMeteredEmbeddingProviderWrapper(but can further rename with better name).Which issue(s) this PR fixes:
N/A
Checklist