fix: Check credentials secret for trivial values#747
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #349.
The parent issues dates from 11/2023 and the behaviour seems to have changed since then. Deserialization errors are thrown if either
clusterConfigis omitted entirely orcredentialsSecretis omitted (or a value is missing). An error appears on the StatefulSet if only a quoted empty string is supplied.With this PR, a deserialization error is thrown that catches both empty/missing cases:
Kind=AirflowCluster failed: failed to parse object: failed to deserialize object from JSON: Field cannot be empty or whitespaceHowever, I'm not really sure if this is an improvement as the name of the field is omitted in the message. Previously it was included :
AirflowCluster.airflow.stackable.tech "airflow" is invalid: spec.clusterConfig.credentialsSecret: Required valueDefinition of Done Checklist
Author
Reviewer
Acceptance
type/deprecationlabel & add to the deprecation scheduletype/experimentallabel & add to the experimental features tracker