Skip to content

fix: Check credentials secret for trivial values#747

Open
adwk67 wants to merge 3 commits intomainfrom
fix/default-credential-secret
Open

fix: Check credentials secret for trivial values#747
adwk67 wants to merge 3 commits intomainfrom
fix/default-credential-secret

Conversation

@adwk67
Copy link
Member

@adwk67 adwk67 commented Feb 17, 2026

Description

Fixes #349.

The parent issues dates from 11/2023 and the behaviour seems to have changed since then. Deserialization errors are thrown if either clusterConfig is omitted entirely or credentialsSecret is omitted (or a value is missing). An error appears on the StatefulSet if only a quoted empty string is supplied.

With this PR, a deserialization error is thrown that catches both empty/missing cases:

Kind=AirflowCluster failed: failed to parse object: failed to deserialize object from JSON: Field cannot be empty or whitespace

However, I'm not really sure if this is an improvement as the name of the field is omitted in the message. Previously it was included :

AirflowCluster.airflow.stackable.tech "airflow" is invalid: spec.clusterConfig.credentialsSecret: Required value

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes

Author

  • Changes are OpenShift compatible
  • CRD changes approved
  • CRD documentation for all fields, following the style guide.
  • Helm chart can be installed and deployed operator works
  • Integration tests passed (for non trivial changes)
  • Changes need to be "offline" compatible
  • Links to generated (nightly) docs added
  • Release note snippet added

Reviewer

  • Code contains useful comments
  • Code contains useful logging statements
  • (Integration-)Test cases added
  • Documentation added or updated. Follows the style guide.
  • Changelog updated
  • Cargo.toml only contains references to git tags (not specific commits or branches)

Acceptance

  • Feature Tracker has been updated
  • Proper release label has been added
  • Links to generated (nightly) docs added
  • Release note snippet added
  • Add type/deprecation label & add to the deprecation schedule
  • Add type/experimental label & add to the experimental features tracker

@adwk67 adwk67 marked this pull request as ready for review February 17, 2026 11:03
@adwk67 adwk67 moved this to Development: Waiting for Review in Stackable Engineering Feb 17, 2026
@adwk67 adwk67 self-assigned this Feb 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Development: Waiting for Review

Development

Successfully merging this pull request may close these issues.

credentialsSecret is a required field, but also has the empty string as a default value

1 participant