fixup pipBulkShow function to prevent breaking with numerous names#83
fixup pipBulkShow function to prevent breaking with numerous names#83ficapy wants to merge 1 commit intosourcegraph:scipfrom
Conversation
|
Same here if my project using some large libs like |
|
Hi, Same thing here, passing The proposed fix of extending the buffer size to 10MB seems good enough for a first attempt. In the future this can be switched to a parsing window but requires switching to async logic as far as I understand. Are there pending tasks for this PR? |
Titou325
left a comment
There was a problem hiding this comment.
Both execSync and spawnSync allow the maxBuffer option (see https://nodejs.org/docs/latest-v16.x/api/child_process.html#child_processexecsynccommand-options). The refactoring is not needed but good practice.
Looks good to me.
When there are very numerous pip dependencies, execSync will report an error, see https://stackoverflow.com/questions/63796633/spawnsync-bin-sh-enobufs