fix(macOS): prevent crash on quit caused by double shutdown path#2129
Open
msavara wants to merge 1 commit intosourcegit-scm:developfrom
Open
fix(macOS): prevent crash on quit caused by double shutdown path#2129msavara wants to merge 1 commit intosourcegit-scm:developfrom
msavara wants to merge 1 commit intosourcegit-scm:developfrom
Conversation
Fixes a macOS crash during app termination. App.Quit was closing MainWindow and then calling desktop.Shutdown(exitCode). Because the app runs with ShutdownMode.OnMainWindowClose, closing the main window already starts shutdown. Calling desktop.Shutdown again can re enter teardown while native AppKit and Avalonia dispatcher resources are already being finalized, which can end in SIGABRT on quit. The fix keeps a single shutdown path by calling only desktop.Shutdown(exitCode) in App.Quit, and it also adds a detailed inline comment that explains why this is required on macOS.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes a macOS crash during app termination. App.Quit was closing MainWindow and then calling
desktop.Shutdown(exitCode). Because the app runs with ShutdownMode.OnMainWindowClose, closing the main window already
starts shutdown. Calling desktop.Shutdown again can re enter teardown while native AppKit and Avalonia dispatcher
resources are already being finalized, which can end in SIGABRT on quit. The fix keeps a single shutdown path by calling
only desktop.Shutdown(exitCode) in App.Quit, and it also adds a detailed inline comment that explains why this is
required on macOS.