Conversation
✅ Deploy Preview for solid-start-landing-page ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
🦋 Changeset detectedLatest commit: 04f8dc1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lxsmnsyc
approved these changes
Feb 21, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates SolidStart’s Seroval integration and related dependencies, adding a configurable serialization mode for server functions and fixing server function ID header encoding. It also introduces a new fixture app to exercise serialization/CSP behavior and adds a small test route/middleware scaffold.
Changes:
- Bump Seroval / Solid-related dependencies and update workspace/lockfile accordingly.
- Fix
X-Server-Idheader handling by percent-encoding on the client and decoding on the server. - Introduce configurable server-function serialization mode (
jsvsjson) with a new shared serialization module and a new fixture app.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| pnpm-workspace.yaml | Include apps/fixtures/* as workspace packages and normalize quoting. |
| pnpm-lock.yaml | Lockfile updates for new/updated dependencies and new fixture packages. |
| packages/start/src/runtime/server-runtime.ts | Client runtime updates: encode server id header; use new serialization helpers; select stream deserializer by SEROVAL_MODE. |
| packages/start/src/runtime/server-handler.ts | Server handler updates: decode server id header; parse serialized args; emit serialized responses based on SEROVAL_MODE. |
| packages/start/src/runtime/serialization.ts | New shared serialization implementation for JS-stream and Cross-JSON stream modes. |
| packages/start/package.json | Bump Start version and update Seroval / Solid / vite-plugin-solid dependency ranges. |
| packages/start/config/index.js | Add serialization.mode config plumbing and inject import.meta.env.SEROVAL_MODE. |
| packages/start/config/index.d.ts | Type the new serialization.mode option and document behavior. |
| packages/start/CHANGELOG.md | Add 1.2.1 changelog entry referencing Seroval update. |
| apps/tests/src/routes/actions/use-submission.tsx | New test route exercising action() + useSubmission(). |
| apps/tests/src/middleware.ts | Add middleware file with empty onRequest list. |
| apps/fixtures/serialization-modes/tsconfig.json | Fixture TS config for the serialization-modes app. |
| apps/fixtures/serialization-modes/src/routes/index.tsx | Fixture route intended to exercise server function serialization output. |
| apps/fixtures/serialization-modes/src/routes/[...404].tsx | Fixture 404 route. |
| apps/fixtures/serialization-modes/src/middleware.ts | Fixture CSP middleware (Shieldwall) to test eval() restrictions. |
| apps/fixtures/serialization-modes/src/global.d.ts | Fixture env type reference. |
| apps/fixtures/serialization-modes/src/entry-server.tsx | Fixture server entrypoint. |
| apps/fixtures/serialization-modes/src/entry-client.tsx | Fixture client entrypoint. |
| apps/fixtures/serialization-modes/src/components/Counter.tsx | Fixture counter component. |
| apps/fixtures/serialization-modes/src/components/Counter.css | Fixture styling for counter component. |
| apps/fixtures/serialization-modes/src/app.tsx | Fixture app shell and routing setup. |
| apps/fixtures/serialization-modes/src/app.css | Fixture app styling. |
| apps/fixtures/serialization-modes/public/favicon.ico | Fixture favicon asset. |
| apps/fixtures/serialization-modes/package.json | Fixture package definition and dependencies. |
| apps/fixtures/serialization-modes/app.config.ts | Fixture config enabling serialization mode selection. |
| apps/fixtures/serialization-modes/README.md | Fixture README describing JS vs JSON mode behavior under CSP. |
| .changeset/icy-rings-exist.md | Changeset declaring a minor bump for “seroval json mode”. |
| .changeset/fix-server-id-encoding.md | Changeset declaring a patch bump for header encoding fix. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.