Skip to content

Comments

Improve DX and test-cases on seroval mode#2073

Merged
atilafassina merged 7 commits intofeat-seroval-json-1.xfrom
seroval-json/dx
Feb 21, 2026
Merged

Improve DX and test-cases on seroval mode#2073
atilafassina merged 7 commits intofeat-seroval-json-1.xfrom
seroval-json/dx

Conversation

@atilafassina
Copy link
Member

  • Keep "js" as the default for V1
  • Add warnings and JSDoc for configuration options
  • Add a fixture to easily swap between modes and test them out

@atilafassina atilafassina self-assigned this Feb 21, 2026
Copilot AI review requested due to automatic review settings February 21, 2026 09:55
@changeset-bot
Copy link

changeset-bot bot commented Feb 21, 2026

⚠️ No Changeset found

Latest commit: 950405a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@pkg-pr-new
Copy link

pkg-pr-new bot commented Feb 21, 2026

Open in StackBlitz

npm i https://pkg.pr.new/@solidjs/start@2073

commit: 950405a

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves the developer experience for working with Seroval serialization modes in SolidStart. It maintains "js" as the default serialization mode for V1 compatibility while adding comprehensive documentation and a dedicated fixture application for testing different serialization behaviors.

Changes:

  • Added JSDoc documentation for the serialization.mode configuration option with warnings about V2 default changes
  • Refactored serialization mode configuration to use a single variable across all router configurations
  • Created a new serialization-modes fixture app to demonstrate and test CSP compatibility with different serialization modes
  • Added middleware with security headers to the tests app

Reviewed changes

Copilot reviewed 18 out of 22 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
packages/start/config/index.js Refactored to use a single serializationMode variable instead of repeating the default logic
packages/start/config/index.d.ts Added comprehensive JSDoc documentation for serialization mode configuration
pnpm-workspace.yaml Added fixture subdirectories to workspace packages
pnpm-lock.yaml Added dependencies for new fixtures (shieldwall, date-fns, marked, unstorage, csp-header)
apps/tests/src/middleware.ts Added security middleware using shieldwall (CSP, CSRF protection)
apps/tests/src/routes/actions/use-submission.tsx Added test case for useSubmission hook
apps/fixtures/serialization-modes/* Complete new fixture app demonstrating serialization mode differences and CSP interactions
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

atilafassina and others added 6 commits February 21, 2026 11:01
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@atilafassina atilafassina merged commit 1958520 into feat-seroval-json-1.x Feb 21, 2026
2 checks passed
@atilafassina atilafassina deleted the seroval-json/dx branch February 21, 2026 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants