Skip to content

fix: percent-encode x-server-id header value #2071

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
atilafassina merged 2 commits into from
Feb 20, 2026
Merged

fix: percent-encode x-server-id header value #2071

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3e0ef73
Initial plan
Copilot Feb 20, 2026
9683199
chore: add changeset for server id encoding fix
Copilot Feb 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/fix-server-id-encoding.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@solidjs/start": patch
---

fix: use percent encoding for `x-server-id` header value instead of reserved `#` character
Comment on lines +1 to +5
Copy link

Copilot AI Feb 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR currently only adds a changeset, but the described behavioral fix (percent-encoding the X-Server-Id header value) doesn’t appear in the diff. Also, the current implementation already sets X-Server-Id using percent encoding (see packages/start/src/runtime/server-runtime.ts:128), so this changeset may be inaccurate or may ship a patch with no actual code change. Please either include the corresponding code change in this PR or adjust the PR/changelog to reflect the actual delta being released.

Copilot uses AI. Check for mistakes.
Loading