Skip to content

Conversation

@waleedlatif1
Copy link
Collaborator

Summary

  • use recommended query param pattern for confluence route

Type of Change

  • Improvement

Testing

Tested manually

Checklist

  • Code follows project style guidelines
  • Self-reviewed my changes
  • Tests added/updated and passing
  • No new warnings introduced
  • I confirm that I have read and agree to the terms outlined in the Contributor License Agreement (CLA)

@vercel
Copy link

vercel bot commented Feb 11, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

1 Skipped Deployment
Project Deployment Actions Updated (UTC)
docs Skipped Skipped Feb 11, 2026 10:59pm

Request Review

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.

@waleedlatif1 waleedlatif1 merged commit 3a3bddd into staging Feb 11, 2026
3 checks passed
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 11, 2026

Greptile Overview

Greptile Summary

Updated the Confluence DELETE label endpoint to use query parameter pattern (?name=) instead of path parameter pattern for the label name, aligning with Atlassian's recommended API conventions.

  • Changed URL from .../label/{encodedLabel} to .../label?name={encodedLabel} on route.ts:240
  • Unused variable encodedLabel remains on line 239 and should be removed

Confidence Score: 4/5

  • Safe to merge with minor cleanup recommended
  • The core change correctly updates the API endpoint pattern to align with Atlassian's recommended approach. The only issue is a minor unused variable that doesn't affect functionality
  • No files require special attention

Important Files Changed

Filename Overview
apps/sim/app/api/tools/confluence/labels/route.ts Changed DELETE endpoint URL from path parameter to query parameter pattern, minor cleanup needed for unused variable

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@@ -237,7 +237,7 @@ export async function DELETE(request: NextRequest) {
}

const encodedLabel = encodeURIComponent(labelName.trim())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unused variable encodedLabel

Suggested change
const encodedLabel = encodeURIComponent(labelName.trim())
const url = `https://api.atlassian.com/ex/confluence/${cloudId}/wiki/rest/api/content/${pageId}/label?name=${encodeURIComponent(labelName.trim())}`

waleedlatif1 added a commit that referenced this pull request Feb 12, 2026
…3202)

* fix(confl): use recommended query param pattern for confluence route

* use unused var
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant