Change BASE_REF to use github.ref instead of github.base_ref #129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In rufus downstream the base ref is always null, which leads to issues as it then falls back to installing trunk of the dependencies , however the ref might already contain the correct release branch
Use github.base_ref as fallback for BASE_REF.
Contributor
Author
|
This should fix the issues here: https://github.com/shopware/Rufus/actions/runs/21897426840/job/63216696280 where we run rufus downstream from platform PR targeting 6.7.7.x release branch, which correctly checks out 6.7.7.x version of rufus, but falls back here to install commercial trunk see triggering platform PR: shopware/shopware#14893 |
MalteJanz
approved these changes
Feb 11, 2026
mkraeml
approved these changes
Feb 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In rufus downstream the base ref is always null, which leads to issues as it then falls back to installing trunk of the dependencies , however the ref might already contain the correct release branch