Skip to content

[Fix #1141] Perform conversion for completable future #1150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fjtirado merged 1 commit into from
Feb 10, 2026
Merged

[Fix #1141] Perform conversion for completable future #1150

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions ...bda/src/main/java/io/serverlessworkflow/impl/executors/func/AbstractJavaCallExecutor.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,10 +38,11 @@ protected AbstractJavaCallExecutor(Optional<Class<T>> inputClass) {
@Override
public CompletableFuture<WorkflowModel> apply(
WorkflowContext workflowContext, TaskContext taskContext, WorkflowModel input) {
Object result = callJavaFunction(workflowContext, taskContext, model2Input(input));
Object result =
convertResponse(callJavaFunction(workflowContext, taskContext, model2Input(input)));
WorkflowModelFactory modelFactory = workflowContext.definition().application().modelFactory();
return result instanceof CompletableFuture future
? future.thenApply(v -> output2Model(modelFactory, input, v))
? future.thenApply(v -> output2Model(modelFactory, input, convertResponse(v)))
: CompletableFuture.completedFuture(output2Model(modelFactory, input, result));
}

Expand All @@ -60,6 +61,6 @@ protected Object convertResponse(Object obj) {

protected WorkflowModel output2Model(
WorkflowModelFactory modelFactory, WorkflowModel input, Object result) {
return modelFactory.fromAny(input, convertResponse(result));
return modelFactory.fromAny(input, result);
}
}