-
Notifications
You must be signed in to change notification settings - Fork 28
Add support for grid gutters to control spacing between grid items #693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add support for grid gutters to control spacing between grid items #693
Conversation
✅ Deploy Preview for scientific-python-hugo-theme ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
The deployment failure is just the link checker plugin. This has been ready for review; sites are building fine! |
stefanv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Two small comments, but also OK to just merge this directly.
c08651b to
f37a01a
Compare

This PR closes #596. This was already supported in our sphinx-design CSS, just that we didn't expose it as a parameter in the
gridshortcode, so it was partially implemented (no pun intended :P).The spacing scale formula is defined here:
scientific-python-hugo-theme/assets/theme-css/sphinx-design/_spacing.scss
Lines 1 to 9 in b3056c3
which generates the responsive
sd-g-*classes that control the--sd-gutter-xand--sd-gutter-yvariables.The gutter parameter can either take one or four integers between 0 to 5. The default is 2 for backwards compatibility. The four integers in the value, if set, correspond to the
xs/sm/md/lgbreakpoints. See the Bootstrap docs for more, which is what sphinx-design relies on: https://getbootstrap.com/docs/5.2/layout/grid/#grid-options