Save ZJIT stats_string to JSON output for stats collection#475
Merged
Save ZJIT stats_string to JSON output for stats collection#475
Conversation
When RubyVM::ZJIT.stats_enabled? is true and stats_string is available, include it in the JSON output as zjit_stats_string so rubybench can read it from the result file.
tekknolagi
approved these changes
Feb 12, 2026
Contributor
tekknolagi
left a comment
tekknolagi
left a comment
There was a problem hiding this comment.
nice. will we be able to track stats deltas across days?
Member
Author
|
I'm not planning on doing that; that should probably be achieved by a separate view that renders stats in a graph, not by stats strings. |
Member
Author
|
I just wanted to stop updating the stats string snapshot in our ruby-bench perf burndown issues manually. That's all. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR stores
RubyVM::ZJIT.stats_stringinto the JSON output file if--zjit-statsis enabled. I want to add a feature to rubybench that runs--zjit-statsand shows the stats string on the website.