Skip to content

Update zjit_diff to report on stat keys from all rubies #473

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rwstauner merged 1 commit into from
Feb 12, 2026
Merged

Update zjit_diff to report on stat keys from all rubies #473

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions misc/zjit_diff.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,9 @@ def print_uncategorized_stats
stats_by_ruby = @ruby_names.map { |r| [@raw_data.dig(r, bench_name, 'zjit_stats'), r] }
next if stats_by_ruby.any? { |s, _| s.nil? }

unknown_keys = stats_by_ruby.first[0].keys.select do |k|
stats_by_ruby.first[0][k].is_a?(Numeric) && !known_stat?(k)
all_keys = stats_by_ruby.flat_map { |s, _| s.keys }.uniq
unknown_keys = all_keys.select do |k|
stats_by_ruby.any? { |s, _| s[k].is_a?(Numeric) } && !known_stat?(k)
end

significant = filter_significant_keys(stats_by_ruby, unknown_keys)
Expand Down Expand Up @@ -230,7 +231,7 @@ def print_send_counters
stats_by_ruby = @ruby_names.map { |r| [@raw_data.dig(r, bench_name, 'zjit_stats'), r] }
next if stats_by_ruby.any? { |s, _| s.nil? }

keys = SEND_COUNTERS.map(&:to_s).select { |k| stats_by_ruby.first[0].key?(k) }
keys = SEND_COUNTERS.map(&:to_s).select { |k| stats_by_ruby.any? { |s, _| s.key?(k) } }
significant = filter_significant_keys(stats_by_ruby, keys)
next if significant.empty?

Expand All @@ -253,7 +254,7 @@ def print_summary_counters
stats_by_ruby = @ruby_names.map { |r| [@raw_data.dig(r, bench_name, 'zjit_stats'), r] }
next if stats_by_ruby.any? { |s, _| s.nil? }

keys = SUMMARY_COUNTERS.map(&:to_s).select { |k| stats_by_ruby.first[0].key?(k) }
keys = SUMMARY_COUNTERS.map(&:to_s).select { |k| stats_by_ruby.any? { |s, _| s.key?(k) } }
significant = filter_significant_keys(stats_by_ruby, keys)
next if significant.empty?

Expand Down Expand Up @@ -283,7 +284,7 @@ def print_category_diff(prefix, prompt, limit = nil)
stats_by_ruby = @ruby_names.map { |r| [@raw_data.dig(r, bench_name, 'zjit_stats'), r] }
next if stats_by_ruby.any? { |s, _| s.nil? }

keys = stats_by_ruby.first[0].keys.select { |k| k.start_with?(prefix) }
keys = stats_by_ruby.flat_map { |s, _| s.keys }.uniq.select { |k| k.start_with?(prefix) }
significant = filter_significant_keys(stats_by_ruby, keys)

next if significant.empty?
Expand Down
Loading