fix: skip extra newline when merging adjacent Markdown list items

[Timeless0911]

Description

When merging Markdown sections (AGENTS.md), an extra newline was always added between content blocks. This PR adds a check to skip this newline if both the end of the current block and the start of the next block are list items (starting with - ). This ensures unordered lists from different sources are merged into a single continuous list.

before

after

Changes

• Updated mergeAgentsFiles in src/index.ts to skip newline for adjacent - list items.
• Added comprehensive unit tests in test/agents.test.ts to verify the behavior and handle edge cases like horizontal rules.

[gemini-code-assist]

Summary of Changes

Hello @Timeless0911, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the Markdown merging functionality by addressing an issue where an unnecessary newline was inserted between adjacent list items. The change ensures that when Markdown sections containing unordered lists are merged, the lists remain continuous and properly formatted, enhancing the readability and structural integrity of the combined document. This improvement is supported by new tests covering various merging scenarios.

Highlights

• Markdown List Merging: Implemented logic within mergeAgentsFiles to prevent the addition of an extra newline when merging two adjacent Markdown list items (starting with - ). This ensures that unordered lists from different sources are combined into a single, continuous list.
• Comprehensive Unit Tests: Added new unit tests to test/agents.test.ts to thoroughly verify the new list merging behavior, including scenarios with non-list content and horizontal rules, ensuring correct newline handling in various contexts.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• src/index.ts
  • Modified mergeAgentsFiles to introduce conditional newline skipping based on content type.
• test/agents.test.ts
  • Added new test cases for mergeAgentsFiles to verify correct merging of unordered lists.
  • Included tests for scenarios involving non-list content and horizontal rules to ensure proper newline behavior.

Activity

• No human activity has been recorded on this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly addresses an issue where an extra newline was added when merging adjacent Markdown list items. The logic in src/index.ts has been updated to conditionally skip this newline, and comprehensive unit tests have been added in test/agents.test.ts to validate the new behavior. The changes are well-implemented. I have one suggestion to improve the performance of string manipulation in src/index.ts.

[chenjiahan]

👍