use Go 1.25 + 1.26, bump golangci-lint#1144
Merged
Conversation
brandur
approved these changes
Feb 11, 2026
| module github.com/riverqueue/river/cmd/river | ||
|
|
||
| go 1.24.0 | ||
| go 1.25.0 |
Contributor
There was a problem hiding this comment.
Similar to comment on other PR — should we just bump this to 1.26?
Contributor
Author
There was a problem hiding this comment.
Per offline convo, this turns out to be the minimum supported Go version and users can't user install the package on a Go version lower than this.
Keeping with our policy of supporting the latest major Go release as well as the prior one, this upgrades the project to a minimum of Go 1.25 now that 1.26 has been released.
bgentry
force-pushed
the
bgentry/go125-126-upgrade
branch
from
e336ce9 to
bbc1379
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keeping with our policy of supporting the latest major Go release as well as the prior one, this upgrades the project to a minimum of Go 1.25 now that 1.26 has been released.
In the process, I adopted a workaround for golangci-lint to pin it to run with 1.25 since its current build fails/panics against Go 1.26