Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read the file from the buffer instead of disk. See: rescript-lang/rescript#8250
I also added debounce so it doesn't fire on each keystroke.
Compatibilty:
This is considered breaking changes because now
inlayHinttakes an extra argument (7 arguments instead of 6).The relevant inlay hint function in analysis also expect 7 arguments.
The only time the extension will break is when the extension (with this fix) is used with analysis binary without the fix.
currentFiletoNonewhen received with 6 args. See https://github.com/rescript-lang/rescript-vscode/pull/1179/changes#diff-3af5ac9f37422b6630f5e2a41045fa987a4ec2c8c8ec3f73904b08b55b8b1a64R164-R171@zth what would be the best way to handle this?