8342 8349 application graph view#178
8342 8349 application graph view#178keithchong wants to merge 2 commits intoredhat-developer:mainfrom
Conversation
Signed-off-by: Keith Chong <kykchong@redhat.com>
Signed-off-by: Keith Chong <kykchong@redhat.com>
keithchong
force-pushed
the
8342-8349-ApplicationGraphView2
branch
from
d62b390 to
81460b5
Compare
| graph: { | ||
| id: 'g1', | ||
| type: 'graph', | ||
| layout: 'PipleineDagreLayout', |
| } else if (label === t('Delete Application')) { | ||
| launchDeleteModal(); | ||
| } else if ( | ||
| label === 'Show ' + graphElement.getData().kindPlural || |
There was a problem hiding this comment.
use t function here and the line below?
| <SvgTextWithOverflow text={`${data.healthyCount} Healthy`} maxWidth={200} x="69" y="40" /> | ||
| )} | ||
| {/* eslint-disable no-nested-ternary */} | ||
| {data.hasProgressing ? ( |
There was a problem hiding this comment.
Is this intentional? The status text rendering prioritizes: Progressing > Missing > Degraded > Suspended > Unknown
The status icon rendering below prioritizes: Progressing > Degraded > Missing > Suspended > Unknown
| )} | ||
| </svg> | ||
| <line x1="45" y1="0" x2="45" y2="70" stroke="gray" strokeWidth="1" /> | ||
| {data.healthyCount === data.resourceCount && ( |
There was a problem hiding this comment.
HeartIcon here renders when healthyCount === resourceCount and the status icons (around lines132) render based on has* flags. Icons might overlap at the same position if both are true?
| }; | ||
| } | ||
| const nodeId = resource.kind + '-' + resource.name + '-' + resource.namespace; | ||
| groupResourceNode.data.resourceChildrenIds = [ |
There was a problem hiding this comment.
The resourceChildrenIds array stores IDs without the count prefix, but the actual nodes created at line 339 use IDs with the count prefix.
| ), | ||
| rank: 0, | ||
| nodeStatus: nodeStatus, | ||
| reourceHealthStatus: application?.status?.health?.status, |
There was a problem hiding this comment.
| reourceHealthStatus: application?.status?.health?.status, | |
| resourceHealthStatus: application?.status?.health?.status, |
| style={{ fill: `${ARGO_GRAY4_COLOR}` }} | ||
| /> | ||
| ); | ||
| break; |
There was a problem hiding this comment.
should add default case here?
2 participants
See GitOps-8342 and 8349