Skip to content

fix: remove devtools panel from focus order when closed#229

Open
professorplumb wants to merge 1 commit intoreact-hook-form:masterfrom
professorplumb:no-focus-while-hidden
Open

fix: remove devtools panel from focus order when closed#229
professorplumb wants to merge 1 commit intoreact-hook-form:masterfrom
professorplumb:no-focus-while-hidden

Conversation

@professorplumb
Copy link

Fixes #198

Testing:

  • Ensure yarn install has been run in both the repo root and the example subdirectory
  • cd example && yarn run dev
  • Go to http://localhost:5173
  • Use the Tab key to cycle through links and inputs on the page (Shift+Tab if you need to go backward).
    • On master, there will be several "invisible" focus stops after the submit button, where you press Tab repeatedly but nothing is focused. These correspond to the unseen inputs inside the hidden DevTools panel, which incorrectly receive focus as described in the linked issue.
    • On this branch, keyboard focus should go directly from the Submit button to the DevTools logo in the upper right.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Elements inside the DevTools shouldn't be focusable when the DevTools are closed

1 participant