Fix :Exclude zero-valued same-spin two-body terms in generate_hamiltonian #1129
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Similar to the other PR I just commented on, I recommend running tests locally and debugging the changes locally because that will be easier and faster than waiting for CI checks. This PR currently fails checks; it doesn't look like this code change is correct by itself. |
Author
|
Apologies for missing this earlier, I’ll be fixing it soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#856
This pull request fixes issue by adding a condition to the
generate_hamiltonianfunction that skips the inclusion of two-body Hamiltonian terms with repeated creation .