Skip to content

[django-filter] fix return type for MultipleChoiceFilter.get_filter_predicate #15418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
srittau merged 2 commits into from
Feb 12, 2026
+2 −2
Merged

[django-filter] fix return type for MultipleChoiceFilter.get_filter_predicate #15418

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd5cd86
fix return type for MultipleChoiceFilter.get_filter_predicate
bckohan Feb 11, 2026
d747afc
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions stubs/django-filter/django_filters/filters.pyi
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ from collections.abc import Callable, Iterable
from typing import Any

from django import forms
from django.db.models import Q, QuerySet
from django.db.models import QuerySet
from django.forms import Field
from django_stubs_ext import StrOrPromise

Expand Down Expand Up @@ -131,7 +131,7 @@ class MultipleChoiceFilter(Filter):
) -> None: ...
def is_noop(self, qs: QuerySet[Any], value: Any) -> bool: ... # Value can be any filter input
def filter(self, qs: QuerySet[Any], value: Any) -> QuerySet[Any]: ...
def get_filter_predicate(self, v: Any) -> Q: ... # Predicate value can be any filter input type
def get_filter_predicate(self, v: Any) -> dict[str, Any]: ... # Predicate value can be any filter input type

class TypedMultipleChoiceFilter(MultipleChoiceFilter):
field_class: type[forms.TypedMultipleChoiceField] # More specific than parent MultipleChoiceField
Expand Down