Fix undetected submodule deletion on warm run #20784
Merged
+76
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
According to mypy_primer, this change doesn't affect type check results on a corpus of open source code. ✅ |
JukkaL
approved these changes
Feb 12, 2026
Collaborator
JukkaL
left a comment
JukkaL
left a comment
There was a problem hiding this comment.
Thanks for fixing another high-pri bug!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7277
This mirrors an old fix for the opposite scenario. Note that although it looks like this PR will make performance impact it should not, because a missing dependency that is present in cache means stale cache anyway.
Note I also make a tiny correctness tweak in the old fix mentioned above:
follow_importsis a per-module option so it must be cloned for the module being imported, not for the importer. This still leaves a tiny correctness issue I describe in the comment, but I don't think it is possible to fix it without massive performance penalty, and it probably doesn't affect anyone anyway.