Skip to content

gh-145089: Fix frozendict constructor #145128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 1 commit into from
Feb 23, 2026
+10 −1
Merged

gh-145089: Fix frozendict constructor #145128

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions Lib/test/test_dict.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1736,6 +1736,16 @@ class FrozenDictSlots(frozendict):


class FrozenDictTests(unittest.TestCase):
def test_constructor(self):
# frozendict.__init__() has no effect
d = frozendict(a=1, b=2, c=3)
d.__init__(x=1)
self.assertEqual(d, frozendict(a=1, b=2, c=3))

# dict constructor cannot be used on frozendict
with self.assertRaises(TypeError):
dict.__init__(d, x=1)

def test_copy(self):
d = frozendict(x=1, y=2)
d2 = d.copy()
Expand Down
1 change: 0 additions & 1 deletion Objects/dictobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8143,7 +8143,6 @@ PyTypeObject PyFrozenDict_Type = {
.tp_richcompare = dict_richcompare,
.tp_iter = dict_iter,
.tp_methods = frozendict_methods,
.tp_init = dict_init,
.tp_alloc = _PyType_AllocNoTrack,
.tp_new = frozendict_new,
.tp_free = PyObject_GC_Del,
Expand Down
Loading