gh-145064: Fix JIT assertion failure during CALL_ALLOC_AND_ENTER_INIT side exit#145100
Open
cocolato wants to merge 2 commits intopython:mainfrom
Open
gh-145064: Fix JIT assertion failure during CALL_ALLOC_AND_ENTER_INIT side exit#145100cocolato wants to merge 2 commits intopython:mainfrom
cocolato wants to merge 2 commits intopython:mainfrom
Conversation
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
CALL_ALLOC_AND_ENTER_INITcreates an instance of a heap type (with__slots__andtp_new == object.__new__), it pushes a shim frame via_PyFrame_PushTrampolineUnchecked. This shim frame hasf_funcobj = Py_None:cpython/Include/internal/pycore_interpframe.h
Line 368 in 2be2dd5
If a JIT trace runs out of buffer space exactly at this shim frame's
EXIT_INIT_CHECKinstruction, the_EXIT_TRACEterminator hands off to a_COLD_EXITexecutor, which calls_PyJit_TryInitializeTracing()with the shim frame. The existing guard only checkedfunc == NULL, butPy_Noneis not NULL, so control falls through which casue assertion crash.co != NULLassertion failure in*_Py_uop_frame_new#145064