gh-145092: fix discards const qualifier from pointer#145093
Merged
serhiy-storchaka merged 2 commits intopython:mainfrom Feb 22, 2026
Merged
gh-145092: fix discards const qualifier from pointer#145093serhiy-storchaka merged 2 commits intopython:mainfrom
serhiy-storchaka merged 2 commits intopython:mainfrom
Conversation
Since glibc-2.43 and ISO C23, the functions bsearch, memchr, strchr, strpbrk, strrchr, strstr, wcschr, wcspbrk, wcsrchr, wcsstr and wmemchr that return pointers into their input arrays now have definitions as macros that return a pointer to a const-qualified type when the input argument is a pointer to a const-qualified type. wchar_t * pointer returns are only being used for comparisons so declare then as const, which matches the input variables.
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
kumaraditya303
approved these changes
Feb 22, 2026
Since glibc-2.43 and ISO C23, the functions bsearch, memchr, strchr, strpbrk, strrchr, strstr, wcschr, wcspbrk, wcsrchr, wcsstr and wmemchr that return pointers into their input arrays now have definitions as macros that return a pointer to a const-qualified type when the input argument is a pointer to a const-qualified type. candidate * pointer returns are only being used for comparisons so declare them as const, which matches the input variables.
serhiy-storchaka
added
needs backport to 3.13
|
Thanks @heitbaum for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13. |
|
Thanks @heitbaum for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 22, 2026
…ning const pointer (pythonGH-145093) (cherry picked from commit faea32b) Co-authored-by: Rudi Heitbaum <rudi@heitbaum.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 22, 2026
…ning const pointer (pythonGH-145093) (cherry picked from commit faea32b) Co-authored-by: Rudi Heitbaum <rudi@heitbaum.com>
|
GH-145101 is a backport of this pull request to the 3.13 branch. |
|
GH-145102 is a backport of this pull request to the 3.14 branch. |
serhiy-storchaka
pushed a commit
that referenced
this pull request
Feb 22, 2026
serhiy-storchaka
pushed a commit
that referenced
this pull request
Feb 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request title
Description
Since glibc-2.43 and ISO C23, the functions bsearch, memchr, strchr, strpbrk, strrchr, strstr, wcschr, wcspbrk, wcsrchr, wcsstr and wmemchr that return pointers into their input arrays now have definitions as macros that return a pointer to a const-qualified type when the input argument is a pointer to a const-qualified type.
wchar_t * pointer returns are only being used for comparisons so declare then as const, which matches the input variables.