Skip to content

gh-145076: Check globals type in __lazy_import__() #145086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vstinner merged 1 commit into from
Feb 21, 2026
+8 −0
Merged

gh-145076: Check globals type in __lazy_import__() #145086

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions Lib/test/test_import/test_lazy_imports.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,8 @@ def test_dunder_lazy_import_invalid_arguments(self):

with self.assertRaises(ValueError):
__lazy_import__("sys", level=-1)
with self.assertRaises(TypeError):
__lazy_import__("sys", globals=1)

def test_dunder_lazy_import_builtins(self):
"""__lazy_import__ should use module's __builtins__ for __import__."""
Expand Down
6 changes: 6 additions & 0 deletions Python/bltinmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -318,6 +318,12 @@ builtin___lazy_import___impl(PyObject *module, PyObject *name,
locals = globals;
}

if (!PyDict_Check(globals)) {
PyErr_Format(PyExc_TypeError,
"expect dict for globals, got %T", globals);
return NULL;
}

if (PyDict_GetItemRef(globals, &_Py_ID(__builtins__), &builtins) < 0) {
return NULL;
}
Expand Down
Loading