gh-131798: Split CHECK_FUNCTION_VERSION into two guards in the JIT#145080
Draft
Sacul0457 wants to merge 1 commit intopython:mainfrom
Draft
gh-131798: Split CHECK_FUNCTION_VERSION into two guards in the JIT#145080Sacul0457 wants to merge 1 commit intopython:mainfrom
CHECK_FUNCTION_VERSION into two guards in the JIT#145080Sacul0457 wants to merge 1 commit intopython:mainfrom
Conversation
Sacul0457
requested review from
Fidget-Spinner,
markshannon,
savannahostrowski and
tomasr8
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR splits up
_CHECK_FUNCTION_VERSIONinto_GUARD_CALLABLE_FUNCTIONand itself. This allows the optimizer to remove thePyFunction_Checkcheck if we know the type. I think the naming can be improved but this is just what I went for.This can be done for
_CHECK_FUNCTION_VERSION_KWtoo but I left that out to keep the change smaller.