gh-145028: Fix blake2 tests in test_hashlib when it is missing due to configure --without-builtin-hashlib-hashes#145029
Merged
gpshead merged 5 commits intopython:mainfrom Feb 21, 2026
Merged
Conversation
…_algorithms_available if implementation is not provided
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
gpshead
reviewed
Feb 20, 2026
…st_algorithms_available
picnixz
reviewed
Feb 20, 2026
- Moved retrieval of PY_BUILTIN_HASHLIB_HASHES out of the loop - Removed guard from test_gil
picnixz
reviewed
Feb 20, 2026
picnixz
reviewed
Feb 20, 2026
- Remove assert for None as that is not a possible return value anyway - Renamed verr to exc - Renamed digest to _ as it is ignored
gpshead
approved these changes
Feb 21, 2026
|
Sorry, @tucif and @gpshead, I could not cleanly backport this to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses Issue #145028 tracking test_hashlib failure on cpython configured
--without-builtin-hashlib-hashesChanges in test_hashlib.py
@require_blake2)algorithmsin constructor when _blake2 is None, as they may already be in that list through its initialization fromself.supported_hashnames.Testing with fix on python without builtin blake2
Sample skips on test_algorithms_available