Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion Lib/copy.py
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,17 @@ def _deepcopy_dict(x, memo, deepcopy=deepcopy):
d[dict] = _deepcopy_dict

def _deepcopy_frozendict(x, memo, deepcopy=deepcopy):
y = _deepcopy_dict(x, memo, deepcopy)
y = {}
for key, value in x.items():
y[deepcopy(key, memo)] = deepcopy(value, memo)

# We're not going to put the frozendict in the memo, but it's still
# important we check for it, in case the frozendict contains recursive
# mutable structures.
try:
return memo[id(x)]
except KeyError:
pass
return frozendict(y)
d[frozendict] = _deepcopy_frozendict

Expand Down
17 changes: 17 additions & 0 deletions Lib/test/test_copy.py
Original file line number Diff line number Diff line change
Expand Up @@ -432,6 +432,23 @@ def test_deepcopy_frozendict(self):
self.assertIsNot(x, y)
self.assertIsNot(x["foo"], y["foo"])

# recursive frozendict
x = frozendict(foo=[])
x['foo'].append(x)
y = copy.deepcopy(x)
self.assertEqual(y.keys(), x.keys())
self.assertIsNot(x, y)
self.assertIsNot(x["foo"], y["foo"])
self.assertIs(y['foo'][0], y)

x = frozendict(foo=[])
x['foo'].append(x)
x = x['foo']
y = copy.deepcopy(x)
self.assertIsNot(x, y)
self.assertIsNot(x[0], y[0])
self.assertIs(y[0]['foo'], y)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add also other assertions similar to the above ones:

        self.assertEqual(y, x)
        self.assertIsNot(x, y)
        self.assertIsNot(x[0], y[0])

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

self.assertEqual(y, x) fails with RecursionError. I added the two other tests.


@support.skip_emscripten_stack_overflow()
@support.skip_wasi_stack_overflow()
def test_deepcopy_reflexive_dict(self):
Expand Down
Loading