GH-145006: add ModuleNotFoundError hints when a module for a differen…#145007
GH-145006: add ModuleNotFoundError hints when a module for a differen…#145007FFY00 merged 6 commits intopython:mainfrom
Conversation
…fferent ABI exists Signed-off-by: Filipe Laíns <lains@riseup.net>
|
Unforetunately, multiple checks seem to be failing, I'll have a look on this |
benediktjohannes
left a comment
There was a problem hiding this comment.
I guess that this should fix the failing tests
Signed-off-by: Filipe Laíns <lains@riseup.net>
|
Thanks for the review @benediktjohannes! I had forgotten we deprecated passing strings to the |
|
Thank you for the fix! You are welcome! |
…ilable Signed-off-by: Filipe Laíns <lains@riseup.net>
Signed-off-by: Filipe Laíns <lains@riseup.net>
Signed-off-by: Filipe Laíns <lains@riseup.net>
Signed-off-by: Filipe Laíns <lains@riseup.net>
|
Reminder for next time, please try and keep the squashed commit message a bit tidier: 1ac9d13. A descriptive commit body isn't necessary, but let's keep out the individual commit messages. I usually remove the whole thing via Refined GitHub. Thanks! |
|
Ah, sorry! Do you know the name of the Refined Github setting to remove the automatically generated squash description? I can't seem to find it. |
|
I use the defaults, and helpfully the merge box shows, this linking to the clear-pr-merge-commit-message rule:
|
ModuleNotFoundErrorhints when a module for a different ABI exists #145006