GH-138800: fix variable substitution in python3.pc for Android#144776
Open
thunder-coding wants to merge 1 commit intopython:mainfrom
Open
GH-138800: fix variable substitution in python3.pc for Android#144776thunder-coding wants to merge 1 commit intopython:mainfrom
thunder-coding wants to merge 1 commit intopython:mainfrom
Conversation
|
The following commit authors need to sign the Contributor License Agreement: |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
Author
Member
|
@thunder-coding if you do not want to sign the CLA with CLA bot you can fill out the form here: https://www.python.org/psf/contrib/contrib-form/ You could also use the bot and revoke the permissions afterwards. It is open source: https://github.com/psf/clabot |
$(BLDLIBRARY) substitution works in Makefiles where variables are expanded at the time of execution. This expansion does not happen in static files like .pc, so use value of BLDLIBRARY instead of trying to substitute the value. Patch stolen from downstream distribution of Python for Termux (Android): termux/termux-packages#27739 Preferably needs to be backported to both Python 3.13 as well as Python 3.14, along with the main branch Fixes python#138800
b134b12 to
e30a3cf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

$(BLDLIBRARY) substitution works in Makefiles where variables are expanded at the time of execution. This expansion does not happen in static files like .pc, so use value of BLDLIBRARY instead of trying to substitute the value.
Patch stolen from downstream distribution of Python for Termux (Android): termux/termux-packages#27739
Preferably needs to be backported to both Python 3.13 as well as Python 3.14, along with the main branch
Fixes #138800