gh-144764: Made dataclasses construct automatic docstrings lazily #144765
+18
−15
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the default docstring construction to occur on-access through a descriptor.
Verified with tprof and this script that generates 10k dataclasses:
Before:
After:
The mean time spent in
_process_class()has dropped from 485μs to 275μs, a ~42% time saving (admittedly skewed due to the small size of the dataclass).