Skip to content

Comments

Move tomlkit dependency to dev group#5990

Merged
rwgk merged 1 commit intopybind:masterfrom
yselkowitz:master
Feb 23, 2026
Merged

Move tomlkit dependency to dev group#5990
rwgk merged 1 commit intopybind:masterfrom
yselkowitz:master

Conversation

@yselkowitz
Copy link
Contributor

Description

tomlkit is used only in the packaging tests which are not ordinarily run as part of the normal workflow of a user or downstream packager.

tomlkit is used only in the packaging tests which are not ordinarily run as
part of the normal workflow of a user or downstream packager.

Signed-off-by: Yaakov Selkowitz <yselkowi@redhat.com>
@rwgk
Copy link
Collaborator

rwgk commented Feb 22, 2026

Looks good to me, but I'm wondering, how did you stumble over this / what problem does this solve? tomlkit is such a light-weight dependency:

$ pip install tomlkit
Collecting tomlkit
  Downloading tomlkit-0.14.0-py3-none-any.whl.metadata (2.8 kB)
Downloading tomlkit-0.14.0-py3-none-any.whl (39 kB)
Installing collected packages: tomlkit
Successfully installed tomlkit-0.14.0

@rwgk rwgk requested a review from henryiii February 22, 2026 20:55
@yselkowitz
Copy link
Contributor Author

Fedora ELN tracks the dependencies of RHEL packages in preparation for the next RHEL major version, and pybind11 is included in RHEL as a dependency of a couple packages. pybind11 3.0 introduced new build dependencies on scikit-build-core and tomlkit. The former seems unavoidable short of changing the project to a different build backend. While tomlkit would indeed not introduce any additional dependencies, since it is not actually needed here to build and test a package from the source tarball, there is no reason to add it.

Copy link
Collaborator

@rwgk rwgk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the explanation!

@rwgk rwgk merged commit 4a77b97 into pybind:master Feb 23, 2026
89 checks passed
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Feb 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs changelog Possibly needs a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants