feat: Add {x,y}gap parameter to heatmaps #385
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrei-ng
reviewed
Feb 11, 2026
| .text(vec!["te", "xt"]) | ||
| .transpose(true) | ||
| .visible(Visible::LegendOnly) | ||
| .x_axis("x") |
Collaborator
There was a problem hiding this comment.
@atticus-sullivan For completeness, could you extend the test with these two setters and the expected json.
With that in place I will merge it.
andrei-ng
approved these changes
Feb 11, 2026
Author
|
I feel almost bad asking 🙈 do you have a "release cycle"? (basically when approximately will this be part of a new release) But I don't want to pressure (especially with that other bug/thing still open ^^), I'm just curious |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see #383 (comment) basically
The docs say there are parameters
{x,y}gapfor heatmap-traces. This PR adds these parameters.See the docs:
In JS they refer to the type as "number greater than or equal to 0" similar in the python docs. By experimenting with the JS version (
plotly-3.3.1.min.js) I can say that (in that version) you can also pass floats and strings. Numbers < 0 seem to be simply "truncated" to 0.Thus I chose to use the
NumOrStringtype, but I'm not 100% on whether that's correct (especially regarding negative numbers).