Add dark mode support #1815
Open
Add dark mode support #1815
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable the theme switcher globally and add CSS dark mode rules. - Remove $config['theme_switcher'] gate so the toggle button appears on all pages - Add html.dark overrides in theme-medium.css for all content areas
lacatoire
requested review from
derickr,
saundefined,
sgolemon and
sy-records
as code owners
Contributor
|
🚀 Preview for commit 6269528 can be found at https://web-php-pr-1815.preview.thephp.foundation |
Contributor
|
🚀 Regression report for commit 6269528 is at https://web-php-regression-report-pr-1815.preview.thephp.foundation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
$config['theme_switcher']gate inheader.inchtml.darkCSS overrides intheme-medium.csscovering all content areas: layout, links, headings, tables, code blocks, syntax highlighting, notes/warnings/tips, user notes, breadcrumbs, sidebar, forms, thanks cards, and moreCloses #1295
Approach
html.darkselector matching the existing JS toggle (common.js):rootsemantic CSS variables first, then targeted overrides for hardcoded hex values