ext/standard Deprecate passing empty string to realpath()#21201
Open
arshidkv12 wants to merge 4 commits intophp:masterfrom
Open
ext/standard Deprecate passing empty string to realpath()#21201arshidkv12 wants to merge 4 commits intophp:masterfrom
arshidkv12 wants to merge 4 commits intophp:masterfrom
Conversation
Member
Deprecation decision needs to be discussed a little.
But is documented behavior.
|
ext/standard Deprecate passing empty string to realpath()
Contributor
Author
|
@devnexen Okay |
Member
|
Seems like an unnecessary BC break, in my opinion. Especially if this is documented, people may rely on this behavior. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecate passing an empty string to the
realpath()php function.Passing an empty string to
realpath()currently resolves to the current working directory. This behavior is implicit and notself-explanatory.
Deprecate this usage and emit
E_DEPRECATED, recommendinggetcwd()instead for retrieving the current working directory.