Unify push & nightly workflows #21172
Open
+260
−462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also introduce label-based opt-in and opt-out mechanism for jobs.
I'll need to make sure this doesn't break the nightly cron.
iluuu1994
force-pushed
the
unify-push-nightly
branch
from
b57f3bf to
35c0da2
Compare
asan && !comprehensive doesn't require setup, so the negation would be !asan || comprehensive.
This was referenced Feb 10, 2026
"Enable all" -> "All jobs" "Disable all" -> "No jobs" "Comprehensive" -> "All variations"
This will be improved for phpGH-14154 anyway.
This is slower than I anticipated
The benchmarking job is independant for push, for now at least.
iluuu1994
force-pushed
the
unify-push-nightly
branch
3 times, most recently
from
b0eadd1 to
1240f09
Compare
TimWolla
reviewed
Feb 12, 2026
Member
TimWolla
left a comment
TimWolla
left a comment
There was a problem hiding this comment.
Did not yet review the changes to nightly.yml. Looked at all other changes.
iluuu1994
force-pushed
the
unify-push-nightly
branch
2 times, most recently
from
c5eb3c2 to
2a16623
Compare
iluuu1994
force-pushed
the
unify-push-nightly
branch
3 times, most recently
from
62b2fc1 to
9e40ace
Compare
iluuu1994
force-pushed
the
unify-push-nightly
branch
from
9e40ace to
5f6cac4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also introduce label-based opt-in and opt-out mechanism for jobs.
TODOs: