Skip to content

test: adapt buffer test for v8 sandbox#61772

Open
codebytere wants to merge 1 commit intonodejs:mainfrom
codebytere:buffer-sandbox
Open

test: adapt buffer test for v8 sandbox#61772
codebytere wants to merge 1 commit intonodejs:mainfrom
codebytere:buffer-sandbox

Conversation

@codebytere
Copy link
Member

@codebytere codebytere commented Feb 11, 2026

Refs #60405

This test will fail for V8 sandboxed builds, where the upper bound will be 2³⁵ - 1 instead of Number.MAX_SAFE_INTEGER.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Feb 11, 2026
@addaleax addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Feb 11, 2026
@codecov
Copy link

codecov bot commented Feb 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 89.75%. Comparing base (04946a7) to head (b1bbd4c).
⚠️ Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #61772      +/-   ##
==========================================
+ Coverage   89.73%   89.75%   +0.01%     
==========================================
  Files         675      675              
  Lines      204648   204648              
  Branches    39330    39330              
==========================================
+ Hits       183651   183684      +33     
+ Misses      13282    13250      -32     
+ Partials     7715     7714       -1     

see 46 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 11, 2026
@nodejs-github-bot
Copy link
Collaborator

@codebytere codebytere added request-ci Add this label to start a Jenkins CI on a PR. and removed needs-ci PRs that need a full CI run. labels Feb 12, 2026
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 12, 2026
@nodejs-github-bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants