vo_gpu_next: use pl deinterlace shader for bwdif instead of sw filter #17394
+27
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasper93
reviewed
Feb 10, 2026
filters/f_auto_filters.c
Outdated
| // We check also if a filter is already present, to avoid removing it | ||
| bool filter_needed = opts->deinterlace == 1 || | ||
| (opts->deinterlace == -1 && (p->interlaced_frame || p->sub.filter)); | ||
| bool filter_needed = (info && info->deinterlace) && (opts->deinterlace == 1 || |
Member
There was a problem hiding this comment.
Isn't this flipped? We don't want filter when deinterlace is supported. Also we might still prefer hardware deint. Might actually need an option, not sure.
Contributor
Author
There was a problem hiding this comment.
Made it only override the software filter, still crashes with hwdec however. I won't have time to look at this for a bit
|
Yes, for some reason bwdif_vulkan stopped working for me after around FFmpeg 7.1, just outputs a green screen instead. No idea what happened but libplacebo's deinterlacing works. |
llyyr
force-pushed
the
pl-deint
branch
3 times, most recently
from
a5e1c86 to
0939147
Compare
Currently a draft because it breaks when changing hwdec during runtime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently a draft because it breaks when changing hwdec during runtime