Don't log the database user version at warn level#7248
Open
badboy wants to merge 1 commit intomozilla:mainfrom
Open
Don't log the database user version at warn level#7248badboy wants to merge 1 commit intomozilla:mainfrom
badboy wants to merge 1 commit intomozilla:mainfrom
Conversation
It's not really an actionable warning, nor does it hold much information.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's not really an actionable warning, nor does it hold much information.
I noticed this in the log of https://app.bitrise.io/build/d935a7a3-107c-4a96-a8ce-36e0c97b9872
from mozilla-mobile/firefox-ios#32151
That line is repeated over and over, even resulting in the total log to be too large for bitrise.
I opted to fully remove it, alternatives would be to lower its severity (debug) or log after the
== 0check (so it's only logged for existing databases, not new ones).