Fix uniffi revision

[bendk]

I messed up the revision on by FFI branch. I picked the first commit, rather than the final commit. The first commit was just some prepatory refactors, so wasn't having any effect.

See https://github.com/mozilla/uniffi-rs/commits/kotlin-pointer-ffi/

Pull Request checklist

• Breaking changes: This PR follows our breaking change policy
  • This PR follows the breaking change policy:
    • This PR has no breaking API changes, or
    • There are corresponding PRs for our consumer applications that resolve the breaking changes and have been approved
• Quality: This PR builds and tests run cleanly
  • Note:
    • For changes that need extra cross-platform testing, consider adding [ci full] to the PR title.
    • If this pull request includes a breaking change, consider cutting a new release after merging.
• Tests: This PR includes thorough tests or an explanation of why it does not
• Changelog: This PR includes a changelog entry in CHANGELOG.md or an explanation of why it does not need one
  • Any breaking changes to Swift or Kotlin binding APIs are noted explicitly
• Dependencies: This PR follows our dependency management guidelines
  • Any new dependencies are accompanied by a summary of the due diligence applied in selecting them.

[mhammond]

lgtm, but the android failure seems odd?

[bendk]

lgtm, but the android failure seems odd?

That was a real issue -- we weren't enabling the pointer-ffi feature. I realized this wasn't so simple, since we're patching the crate. We can't just enable it or else things will fail in moz-central where the patch isn't applied and the feature doesn't exist.

I added this commit to the pointer FFI branch: mozilla/uniffi-rs@c0f8727. It seems to fix things, does it seem okay to you?

[mhammond]

That seems fine to me for this branch only!

[bendk]

Yeah, we definitely should not ever merge that branch.

I'm going to wait until I get back from PTO to merge this one (2/23).

[bendk]

Clippy was failing for nimbus because it's on edition 2024 which has extra clippy checks for using unsafe code in unsafe functions. I tweaked the branch to add more unsafe blocks: https://github.com/mozilla/uniffi-rs/compare/c0f87273413829745a07fc07056617ee79a0d5a9..59b035078322fbc0a605cc3c784cc38214113450

[bendk]

Looks like the tests were passing, but they were taking too much time for the merge queue. I'm bumping the resource class to xlarge to see if that fixes things.

[bendk]

Thanks for merging this! It got into today's nightly, which is great.