Implement PostToolUseFailure hook #294389
Open
+14
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new chat hook type for handling tool failures so hook configuration, parsing, and the proposed API type surface can represent a distinct “post tool use (failure)” lifecycle event.
Changes:
- Extended the proposed
ChatHookTypeunion to includePostToolUseFailure. - Added
PostToolUseFailureto the internal hook type enum/metadata and JSON schema for hook files. - Updated hook parsing/collection to recognize and collect
PostToolUseFailureentries (including Claude compat mapping).
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/vscode-dts/vscode.proposed.chatHooks.d.ts | Extends the proposed API hook type union with PostToolUseFailure. |
| src/vs/workbench/contrib/chat/common/promptSyntax/service/promptsServiceImpl.ts | Ensures hooks of the new type are collected during hook discovery/parse. |
| src/vs/workbench/contrib/chat/common/promptSyntax/hookSchema.ts | Adds the new hook type to the enum, UI metadata list, and hook JSON schema. |
| src/vs/workbench/contrib/chat/common/promptSyntax/hookClaudeCompat.ts | Adds Claude-format name mapping for PostToolUseFailure. |
Comment on lines
14
to
20
| export const CLAUDE_HOOK_TYPE_MAP: Record<string, HookType> = { | ||
| 'SessionStart': HookType.SessionStart, | ||
| 'UserPromptSubmit': HookType.UserPromptSubmit, | ||
| 'PreToolUse': HookType.PreToolUse, | ||
| 'PostToolUse': HookType.PostToolUse, | ||
| 'PostToolUseFailure': HookType.PostToolUseFailure, | ||
| 'PreCompact': HookType.PreCompact, |
There was a problem hiding this comment.
Add/extend unit tests to cover the new Claude hook type mapping for PostToolUseFailure (e.g. resolveClaudeHookType('PostToolUseFailure'), getClaudeHookTypeName(HookType.PostToolUseFailure), and parsing a Claude-format JSON that uses PostToolUseFailure). Right now the test suite only asserts a couple of hook types, so regressions in this new mapping wouldn’t be caught.
pwang347
approved these changes
Feb 11, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.